Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React@18] Upgrade @types to React 18 #194144

Merged
merged 12 commits into from
Oct 1, 2024
Merged

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Sep 26, 2024

Summary

Part of #138222

This PR finilizes the breaking type fixes that are needed for upgrade to React@18.
Most of the remaining issues are muted with "@ts-expect-error" are tricky or could be runtime bugs that need to be looked at.

Since the types changes are backward compatible (except the new APIs) we can upgrade to @types/react@18 now so that we "save" the progress and all the code in Kibana from now on is written in compatbile for react@18 way from types perspective.

@Dosant Dosant added release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Sep 26, 2024
@Dosant Dosant marked this pull request as ready for review September 26, 2024 15:57
@Dosant Dosant requested review from a team as code owners September 26, 2024 15:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM

Copy link
Contributor

@eokoneyo eokoneyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shared UX changes LGTM

Copy link
Contributor

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defend Workflows code review LGTM 🚀

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana-presentation changes LGTM
code review only

Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making these changes!! LGTM for the Threat Hunting Investigations team

Copy link
Contributor

@gergoabraham gergoabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Dosant Dosant enabled auto-merge (squash) October 1, 2024 09:02
@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 1, 2024

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 9f60a5a
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-194144-9f60a5a85f64

Failed CI Steps

Metrics [docs]

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
@kbn/user-profile-components 1 0 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexLifecycleManagement 166.0KB 165.9KB -24.0B
ml 4.6MB 4.6MB +34.0B
searchIndices 92.6KB 92.6KB +7.0B
securitySolution 20.5MB 20.5MB -56.0B
total -39.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant merged commit bdd57b6 into elastic:main Oct 1, 2024
51 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11122738411

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 1, 2024
## Summary

Part of elastic#138222

This PR finilizes the breaking type fixes that are needed for upgrade to
React@18.
Most of the remaining issues are muted with "@ts-expect-error" are
tricky or could be runtime bugs that need to be looked at.

**Since the types changes are backward compatible (except the new APIs)
we can upgrade to @types/react@18 now so that we "save" the progress and
all the code in Kibana from now on is written in compatbile for react@18
way from types perspective.**

(cherry picked from commit bdd57b6)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 1, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[React@18] Upgrade @types to React 18
(#194144)](#194144)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Anton
Dosov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-01T09:40:11Z","message":"[React@18]
Upgrade @types to React 18 (#194144)\n\n## Summary\r\n\r\nPart of
https://github.com/elastic/kibana/issues/138222\r\n\r\nThis PR finilizes
the breaking type fixes that are needed for upgrade
to\r\nReact@18.\r\nMost of the remaining issues are muted with
\"@ts-expect-error\" are\r\ntricky or could be runtime bugs that need to
be looked at.\r\n\r\n**Since the types changes are backward compatible
(except the new APIs)\r\nwe can upgrade to @types/react@18 now so that
we \"save\" the progress and\r\nall the code in Kibana from now on is
written in compatbile for react@18\r\nway from types
perspective.**","sha":"bdd57b64fe19683c481f673d6f1571f91379e730","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","Team:SharedUX","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management","apm:review"],"title":"[React@18]
Upgrade @types to React
18","number":194144,"url":"https://github.com/elastic/kibana/pull/194144","mergeCommit":{"message":"[React@18]
Upgrade @types to React 18 (#194144)\n\n## Summary\r\n\r\nPart of
https://github.com/elastic/kibana/issues/138222\r\n\r\nThis PR finilizes
the breaking type fixes that are needed for upgrade
to\r\nReact@18.\r\nMost of the remaining issues are muted with
\"@ts-expect-error\" are\r\ntricky or could be runtime bugs that need to
be looked at.\r\n\r\n**Since the types changes are backward compatible
(except the new APIs)\r\nwe can upgrade to @types/react@18 now so that
we \"save\" the progress and\r\nall the code in Kibana from now on is
written in compatbile for react@18\r\nway from types
perspective.**","sha":"bdd57b64fe19683c481f673d6f1571f91379e730"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194144","number":194144,"mergeCommit":{"message":"[React@18]
Upgrade @types to React 18 (#194144)\n\n## Summary\r\n\r\nPart of
https://github.com/elastic/kibana/issues/138222\r\n\r\nThis PR finilizes
the breaking type fixes that are needed for upgrade
to\r\nReact@18.\r\nMost of the remaining issues are muted with
\"@ts-expect-error\" are\r\ntricky or could be runtime bugs that need to
be looked at.\r\n\r\n**Since the types changes are backward compatible
(except the new APIs)\r\nwe can upgrade to @types/react@18 now so that
we \"save\" the progress and\r\nall the code in Kibana from now on is
written in compatbile for react@18\r\nway from types
perspective.**","sha":"bdd57b64fe19683c481f673d6f1571f91379e730"}}]}]
BACKPORT-->

Co-authored-by: Anton Dosov <[email protected]>
delanni added a commit that referenced this pull request Oct 2, 2024
## Summary
#191926 introduces something
that's in contradiction with
#194144

This PR adds a fix.
@Dosant Dosant added the React@18 label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:review backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project React@18 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.